Skip to content

fix: Add and test missing mobile Bys #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2021
Merged

fix: Add and test missing mobile Bys #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51d259e
Add and test missing mobile Bys
TroyWalshProf Oct 20, 2021
f3f2f34
Fix docs
TroyWalshProf Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/Appium.Net/Appium/MobileBy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ public static By AndroidUIAutomator(IUiAutomatorStatementBuilder selector) =>
public static new By Name(string selector) => new ByName(selector);

public static new By Id(string selector) => new ById(selector);

public static new By ClassName(string selector) => new ByClassName(selector);

public static new By TagName(string selector) => new ByTagName(selector);
}

/// <summary>
Expand Down Expand Up @@ -472,4 +476,30 @@ public ById(string selector) : base(selector, MobileSelector.Id)
public override string ToString() =>
$"ById({selector})";
}

public class ByTagName : MobileBy
{
/// <summary>
/// Initializes a new instance of the <see cref="ByTagName"/> class.
/// </summary>
/// <param name="selector">Tag name selector.</param>
public ByTagName(string selector) : base(selector, MobileSelector.TagName)
{
}
public override string ToString() =>
$"ByTagName({selector})";
}

public class ByClassName : MobileBy
{
/// <summary>
/// Initializes a new instance of the <see cref="ByClassName"/> class.
/// </summary>
/// <param name="selector">Class name selector.</param>
public ByClassName(string selector) : base(selector, MobileSelector.ClassName)
{
}
public override string ToString() =>
$"ByClassName({selector})";
}
}
10 changes: 10 additions & 0 deletions test/integration/Windows/ClickElementTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,16 @@ public void Addition()
Assert.AreEqual("Display is 8", CalculatorResult.Text);
}

[Test]
public void AdditionWithCompoundBys()
{
_calculatorSession.FindElement(MobileBy.ClassName("ApplicationFrameWindow")).FindElement(MobileBy.Name("One")).Click();
_calculatorSession.FindElement(MobileBy.AccessibilityId("plusButton")).Click();
_calculatorSession.FindElement(MobileBy.Name("Calculator")).FindElement(MobileBy.Name("Five")).Click();
_calculatorSession.FindElement(MobileBy.Name("Equals")).Click();
Assert.AreEqual("Display is 6", CalculatorResult.Text);
}

[Test]
public void Combination()
{
Expand Down