-
Notifications
You must be signed in to change notification settings - Fork 2.7k
prevent merging into supertype field policies #12750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: fafb3d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
size-limit report 📦
|
❌ Docs preview failedThe preview failed to build. Build ID: 57f7632d008f7d99d32a687f ErrorsGeneral: other side closed |
@@ -632,21 +653,10 @@ export class Policies { | |||
|
|||
private getFieldPolicy( | |||
typename: string | undefined, | |||
fieldName: string, | |||
createIfMissing: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createIfMissing: true
was only passed in once, and with these changes it made more sense to solve this a different way, so I inlined that case there and modified it a bit.
4350207
to
4dee1c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
.size-limits.json
Outdated
@@ -1,4 +1,3 @@ | |||
{ | |||
"dist/apollo-client.min.cjs": 42398, | |||
"import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (production)": 34595 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this line removed by accident?
Fixes #12749