Skip to content

Conversation

@BlenderDude
Copy link
Member

Refactors to require strictly defined "request handlers". These handlers have a strict event and response type associated with them, and also allows users of the library to create their own if we do not have a supported event type, or if they are calling the lambda via invoke and need custom parsing.

Middleware was also added in the parsing chain.

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2023

🦋 Changeset detected

Latest commit: 9bcbb1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@as-integrations/aws-lambda Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BlenderDude BlenderDude marked this pull request as ready for review January 18, 2023 14:39
@BlenderDude BlenderDude changed the title Initial request handler work Request Handlers, Custom Extensions, and Middleware, Oh My! Jan 18, 2023
Copy link
Contributor

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Main comment just on the changeset entry then this should be good to go.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bcbb1a:

Sandbox Source
apollo-server-integration-aws-lambda Configuration

Copy link
Contributor

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks in the changeset but LGTM!

@BlenderDude BlenderDude merged commit 5669d23 into main Jan 24, 2023
@BlenderDude BlenderDude deleted the feature/providers-and-middleware branch January 24, 2023 18:51
@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants