-
Notifications
You must be signed in to change notification settings - Fork 10
Request Handlers, Custom Extensions, and Middleware, Oh My! #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9bcbb1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Main comment just on the changeset entry then this should be good to go.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9bcbb1a:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks in the changeset but LGTM!
Refactors to require strictly defined "request handlers". These handlers have a strict event and response type associated with them, and also allows users of the library to create their own if we do not have a supported event type, or if they are calling the lambda via
invokeand need custom parsing.Middleware was also added in the parsing chain.