Added support for ALB event type #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 84028ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trevor-scheer
suggested changes
Oct 20, 2022
trevor-scheer
approved these changes
Nov 21, 2022
src/index.ts
Outdated
| | APIGatewayProxyResult | ||
| | ALBResult | ||
| ) & { | ||
| statusCode: number; |
There was a problem hiding this comment.
Is it ok to assume this? I don't actually know, but the types for APIGatewayProxyStructuredResultV2 include
statusCode?: number | undefined;Are the types lying? (maybe we can submit a PR to correct them if so?)
Asserting type within the tests instead of the runtime leads to more exact runtime types without breaking the test
| httpServer.addListener('request', createMockALBServer(handler)); | ||
| httpServer.addListener( | ||
| 'request', | ||
| createMockALBServer(handler as Handler<ALBEvent, ALBResult>), |
There was a problem hiding this comment.
Yeah, I prefer this cast here instead of in the runtime, good change 👍
Merged
|
Looks like the README could be updated too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the ALB event type. Given that V2 is very similar to ALB, I rewrote some of the normalization logic to condense parsing. Let me know your thoughts on this; after some research, it seems like there is no "official AWS supported way" of knowing exactly what event type has been passed to the Lambda. Given that, I figure we shouldn't try to parse type, and just look for the properties we need within the event object.
I also redid some of the type naming. Renamed
GatewayEventtoIncomingEventto better encapsulate ALB and lambda at edge and CloudFront functions in the future. Marked as a minor change asGatewayEventis removed.