refactor: Hardcode wrapped arrow functions to not specify async key to avoid wrapping non-native promises
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid wrapping non-native promises
timfish
approved these changes
Sep 24, 2025
bengl
approved these changes
Sep 24, 2025
Merged
bizob2828
added a commit
to bizob2828/orchestrion-js
that referenced
this pull request
Sep 25, 2025
…key to avoid wrapping non-native promises (apm-js-collab#48)" This reverts commit 8b43c92.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered an issue with openai. I then traced it back to an issue with tracingChannel.tracePromise. I then realized even if the bug is fixed in Node.js, this library is reintroducing the same issue by adding the
asynckeyword to the wrapped arrow functions. This PR removes specifying theasyncproperty of theArrowExprstruct and just hard code to false to avoid wrapping custom promises in native ones and losing the proper return value.