fix: Properly assign async keyword only to wrapped functions that had async keyword on original
#50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
changed the title
async key to avoid wrapping non-native promises (#48)"async key to avoid wrapping non-native promises
bizob2828
changed the title
async key to avoid wrapping non-native promisesasync keyword only to wrapped functions that had async keyword on original
…ad `async` keyword on original
Qard
approved these changes
Sep 26, 2025
timfish
approved these changes
Sep 26, 2025
jsumners-nr
approved these changes
Sep 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #48 this broke functions that had
awaitstatements in them. Instead of reverting that fix, I updated the code to only assign our wrapped arrow functions with the async keyword when the original function is marked asasync