Skip to content

Conversation

@lewis-wow
Copy link
Contributor

@lewis-wow lewis-wow commented Oct 16, 2025

This pull request introduces a new requestFinished event to enable per-request tracking, complementing the existing socket-level tracking provided by the connectionClosed event. Implements #589

Key Changes:

  • New requestFinished Event: The server now emits a requestFinished event upon the completion of a proxied request. This event provides granular details about each request, including its id, connectionId, and the original request object.
  • Test: Added tests to test/server.js to ensure the requestFinished event is emitted reliably across various proxy configurations, including HTTP, HTTPS, and scenarios with upstream proxies.
  • Example: Included a new example file, examples/request_finished.js, to demonstrate how to listen for and utilize the requestFinished event for monitoring purposes.

This enhancement provides more detailed visibility into individual requests flowing through the proxy, allowing for better logging and tracking.

Reference to previous PR: #590

@github-actions github-actions bot added t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. labels Oct 16, 2025
@lewis-wow lewis-wow added the adhoc Ad-hoc unplanned task added during the sprint. label Oct 22, 2025
@lewis-wow
Copy link
Contributor Author

lewis-wow commented Oct 31, 2025

I am waiting for #602 to be merged so I can use the HTTPS implementation here and mitigate conflicts from large updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants