Skip to content

feat: Refactor(logging): centralize HTTP error logging #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2025
Merged

feat: Refactor(logging): centralize HTTP error logging #336

merged 3 commits into from
Nov 14, 2025

Conversation

@jirispilka
Copy link
Collaborator

@jirispilka jirispilka commented Nov 14, 2025 •
edited
Loading

  • Add logHttpError() utility following apify-core patterns
  • Use softFail for client errors (< 500) and exception for server errors (>= 500)
  • Replace repetitive status code checks across codebase
  • Update validation errors to use softFail instead of error

@github-actions github-actions bot added the t-ai Issues owned by the AI team. label Nov 14, 2025
@jirispilka jirispilka requested a review from novotnyj November 14, 2025 11:00
@jirispilka jirispilka merged commit 7b0a52d into master Nov 14, 2025
4 checks passed
@jirispilka jirispilka deleted the feat/soft-fail-for-client-errors branch November 14, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novotnyj novotnyj novotnyj approved these changes

Assignees

@jirispilka jirispilka

Labels

t-ai Issues owned by the AI team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jirispilka @novotnyj