fix: notifications #145
Merged
fix: notifications #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reamable post sse notifications are sent correctly
github-actions
bot
added
t-ai
MichalKalita
approved these changes
Jun 17, 2025
jirispilka
approved these changes
Jun 17, 2025
Collaborator
jirispilka
left a comment
jirispilka
left a comment
There was a problem hiding this comment.
One small nit. Otherwise, ok. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use MCP request handler extras for notification sending - this is needed so streamable POST SSE notifications work correctly. Also fixes notifications in streamable transport for the standby Actor mode which were not working - this needs POST SSE but it should be safe because the SSE sessions are usually short-lived until all tool call or other requests are finished and then new is created for each POST request.
prerequisite to #69
related to #64