Skip to content

Add precision about behavior of get op. when identifier changes #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 3.4
Choose a base branch
from
Open

Add precision about behavior of get op. when identifier changes #1525

wants to merge 1 commit into from

Conversation

welcoMattic
Copy link
Contributor

@welcoMattic welcoMattic commented Mar 30, 2022 •
edited
Loading

Considering this code

#[ApiProperty(identifier: false)]
public $id;

#[ApiProperty(identifier: true)]
public $code;

The get operation will now expect code value to retrieve the resource.

cc @soyuka

@vinceAmstoutz vinceAmstoutz changed the base branch from 2.6 to 3.4 January 14, 2025 10:33
vinceAmstoutz
vinceAmstoutz approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@vinceAmstoutz vinceAmstoutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @welcoMattic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinceAmstoutz vinceAmstoutz vinceAmstoutz approved these changes

@soyuka soyuka Awaiting requested review from soyuka

@alanpoulain alanpoulain Awaiting requested review from alanpoulain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@welcoMattic @vinceAmstoutz