Skip to content

Conversation

@jasl
Copy link
Contributor

@jasl jasl commented Oct 14, 2025

This is necessary for Nvidia Thor & Spark

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jasl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the project's dependency on CUTLASS to version 4.2.1. This update ensures the project benefits from the latest performance optimizations, bug fixes, and new functionalities introduced in the newer CUTLASS release, maintaining compatibility and leveraging cutting-edge GPU acceleration capabilities.

Highlights

  • CUTLASS Version Upgrade: The CUTLASS submodule has been updated from commit "b2dd65dc864e09688245b316ac46c4a6cd07e15c" to "f3fde58372d33e9a5650ba7b80fc48b3b49d40c8", effectively upgrading the dependency to CUTLASS 4.2.1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the CUTLASS submodule to a new commit, presumably for version 4.2.1 as indicated by the title. While the change is a simple submodule pointer update, dependency upgrades can have significant impacts. The pull request description is currently empty. For maintainability and to facilitate a proper review, it is highly recommended to update the description with: 1) a link to the release notes for CUTLASS 4.2.1, 2) the motivation for the upgrade (e.g., bug fixes, new features, performance improvements), and 3) a summary of the verification performed to ensure that the project builds and all tests pass with this new version.

Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongwww
Copy link
Member

yongwww commented Oct 15, 2025

@jasl please take a look at the test failures

@jasl
Copy link
Contributor Author

jasl commented Oct 15, 2025

@jasl please take a look at the test failures

Not sure why update CUTLASS from v4.2.0 to v4.2.1 causes trouble, but it looks like the failed test has incorrect minimum CUDA arch version

mbarrier.try_wait requires sm_90 or higher. https://docs.nvidia.com/cuda/parallel-thread-execution/index.html?highlight=mbarrier%2520try_wait#parallel-synchronization-and-communication-instructions-mbarrier-test-wait-try-wait

Can you help re-trigger CI?

@jasl
Copy link
Contributor Author

jasl commented Oct 16, 2025

@yongwww CI pass now

@tqchen tqchen merged commit ddf7bce into apache:main Oct 17, 2025
12 checks passed
@jasl jasl deleted the upgrade-cutlass branch October 18, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants