-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Upgrade to CUTLASS 4.2.1 #18372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to CUTLASS 4.2.1 #18372
Conversation
Summary of ChangesHello @jasl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the project's dependency on CUTLASS to version 4.2.1. This update ensures the project benefits from the latest performance optimizations, bug fixes, and new functionalities introduced in the newer CUTLASS release, maintaining compatibility and leveraging cutting-edge GPU acceleration capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the CUTLASS submodule to a new commit, presumably for version 4.2.1 as indicated by the title. While the change is a simple submodule pointer update, dependency upgrades can have significant impacts. The pull request description is currently empty. For maintainability and to facilitate a proper review, it is highly recommended to update the description with: 1) a link to the release notes for CUTLASS 4.2.1, 2) the motivation for the upgrade (e.g., bug fixes, new features, performance improvements), and 3) a summary of the verification performed to ensure that the project builds and all tests pass with this new version.
yongwww
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@jasl please take a look at the test failures |
Not sure why update CUTLASS from v4.2.0 to v4.2.1 causes trouble, but it looks like the failed test has incorrect minimum CUDA arch version
Can you help re-trigger CI? |
|
@yongwww CI pass now |
This is necessary for Nvidia Thor & Spark