-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Relax] Operator and RoPE support for Llama4 #18336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
custom rope for llama4 custom rope for llama4 and ops cleanup rope dead code remove debugging cases reformat moved ml_dtypes import lint fix lint fix remove imports fix tests black format undo lint for 2 lines
Summary of ChangesHello @giterator, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily introduces support for the Llama 4 model, focusing on its unique Rotary Position Embedding (RoPE) scaling mechanism. It includes new functions to handle Llama 4's frequency computation and position mapping within the RoPE implementation. Additionally, the PR expands the frontend operator set with Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Llama4, including a new RoPE implementation, and adds log, floor, and arange operators to the nn frontend. The changes are generally well-implemented. However, the new Llama4 RoPE implementation contains some copy-pasted code from the Llama3 implementation that should be updated for clarity. More importantly, there is significant code duplication in llama4_rope_with_position_map, which should be refactored to improve maintainability.
MasterJH5574
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @giterator!
Added LLama4 implementation, new rope implementation