[FFI][REFACTOR] Update TVM_FFI_STATIC_INIT_BLOCK to fn style #18312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
https://gist.github.com/tqchen/f86ba7c4ce1edad93f85bd6a3b6dffb3 contains a script to do auto migration |
This PR updates TVM_FFI_STATIC_INIT_BLOCK to function style.
Now we do the code as follows, which is cleaner in generally
and also helps error reporting to locate the right place.
TVM_FFI_STATIC_INIT_BLOCK() {
RegisterStaffs();
}
spectrometerHBH
approved these changes
Sep 13, 2025
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Sep 14, 2025
Following apache/tvm#18312, this PR updates the `TVM_FFI_STATIC_INIT_BLOCK` to functional style.
MasterJH5574
added a commit
to mlc-ai/mlc-llm
that referenced
this pull request
Sep 14, 2025
Following apache/tvm#18312, this PR updates the `TVM_FFI_STATIC_INIT_BLOCK` to functional style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates TVM_FFI_STATIC_INIT_BLOCK to function style. Now we do the code as follows, which is cleaner in generally and also helps error reporting to locate the right place.