[FFI][REFACTOR] Streamline Object Declare Macros #18289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR streamlines the macros related to object and ref declaration. - TVM_FFI_DECLARE_BASE_OBJECT_INFO => TVM_FFI_DECLARE_OBJECT_INFO - TVM_FFI_DECLARE_FINAL_OBJECT_INFO => TVM_FFI_DECLARE_OBJECT_INFO_FINAL - Move mutable annotation as field in the object - Auto detect mutablity in object ref getter and operator ptr
Hzfengsy
approved these changes
Sep 9, 2025
Member
Author
Upgrade Guide
For macros that contains _MUTABLE, instead declare _type_mutable=true in the object static field |
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Sep 9, 2025
This PR updates the object declaration macros, in order to follow the recent TVM refactor apache/tvm#18289.
MasterJH5574
added a commit
to mlc-ai/mlc-llm
that referenced
this pull request
Sep 9, 2025
This PR updates the object declaration macros, in order to follow the recent TVM refactor apache/tvm#18289.
Contributor
|
It also looks great to me. Thanks! |
Ubospica
reviewed
Sep 9, 2025
| static constexpr const char* _type_key = "example.MyIntPair"; | ||
| // This macro registers the class with the FFI system to set up the right type index | ||
| TVM_FFI_DECLARE_FINAL_OBJECT_INFO(MyIntPairObj, tvm::ffi::Object); | ||
| TVM_FFI_DECLARE_OBJECT_INFO_FINAL("example.MyIntPair", MyIntPairObj, tvm::ffi::Object); |
| // Required: declare type information | ||
| static constexpr const char* _type_key = "testing.TestIntPair"; | ||
| TVM_FFI_DECLARE_FINAL_OBJECT_INFO(TestIntPairObj, tvm::ffi::Object); | ||
| TVM_FFI_DECLARE_OBJECT_INFO_FINAL("testing.TestIntPair", TestIntPairObj, tvm::ffi::Object); |
Contributor
There was a problem hiding this comment.
Ditto. In markdown we don't have auto formatting.
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines the macros related to object and ref declaration.