[FFI] Construct NDArray.strides by default #18272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Sep 6, 2025
| */ | ||
| inline Shape InferStrideFromShape(Shape shape) { | ||
| size_t ndim = shape.size(); | ||
| Array<int64_t> strides(ndim, 1); |
Member
There was a problem hiding this comment.
do not use array, instead, use https://github.com/apache/tvm/blob/main/ffi/include/tvm/ffi/container/shape.h#L71
details::MakeEmptyShape, then fill in the strides.
do something like
int64_t stride = 1;
for () {
assign
}
We can also move this function to shape.h details::
| explicit NDArrayObjFromDLPack(TDLPackManagedTensor* tensor) : tensor_(tensor) { | ||
| *static_cast<DLTensor*>(this) = tensor_->dl_tensor; | ||
| // set strides to nullptr if the tensor is contiguous. | ||
| if (IsContiguous(tensor->dl_tensor)) { |
Member
There was a problem hiding this comment.
also need to check tensor->dl_tensor->strides == nullptr and act accordingly if needed
| * \return The check result. | ||
| */ | ||
| inline bool IsContiguous(const DLTensor& arr) { | ||
| if (arr.strides == nullptr) return true; |
Member
There was a problem hiding this comment.
keep this for now as this function is defined per DLTensor
tqchen
reviewed
Sep 6, 2025
| return p; | ||
| } | ||
|
|
||
| TVM_FFI_INLINE ObjectPtr<ShapeObj> InferStrideFromShape(int64_t ndim, int64_t* shape) { |
tqchen
approved these changes
Sep 6, 2025
tqchen
approved these changes
Sep 6, 2025
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
This PR updates NDArray.strides to construct strides by default
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
This PR updates NDArray.strides to construct strides by default
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
This PR updates NDArray.strides to construct strides by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the NDArray construction that the strides will be constructed by default.