[Fix] Update FlashInfer JIT header lookup #18244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongwww
approved these changes
Aug 27, 2025
Member
yongwww
left a comment
yongwww
left a comment
There was a problem hiding this comment.
Thanks for the fix! It is helpful. Yeah, requiring both TVM_SOURCE_DIR and TVM_HOME was a bit confusing.
Member
Contributor
Author
@yongwww I remember we renamed all |
This PR fixes the tvm/dlpack/dmlc header lookup in the FlashInfer kernel JIT compilation. Prior to this fix, the JIT compilation assumes the environment variable `TVM_SOURCE_DIR` is always defined, which is not always true. This PR fixes the behavior and considers multiple cases, including TVM source builds and pip-installed packages.
MasterJH5574
force-pushed
the
tvm-dev/2025-08-27-flashinfer-jit-header
branch
from
5e6f1b7 to
c502a73
Compare
Member
|
I see. Thanks, @MasterJH5574 ! |
tqchen
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the tvm/dlpack/dmlc header lookup in the FlashInfer kernel JIT compilation.
Prior to this fix, the JIT compilation assumes the environment variable
TVM_SOURCE_DIRis always defined, which is not always true. This PR fixes the behavior and considers multiple cases, including TVM source builds and pip-installed packages.