Skip to content

[Fix][ONNX] Fixed constant ROI handling in resize2d when loading onnx models #18138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 14, 2025
Merged

[Fix][ONNX] Fixed constant ROI handling in resize2d when loading onnx models #18138

merged 4 commits into from
Jul 14, 2025

Conversation

@ConvolutedDog
Copy link
Contributor

@ConvolutedDog ConvolutedDog commented Jul 12, 2025 •
edited
Loading

This PR fixes #18133 (constant ROI handling in resize2d):

  • Add support for Constant ROI input by converting to numpy array
  • Improve type checking with explicit error for unsupported dynamic ROI
  • Add proper error messaging:
    • Clear NotImplementedError for unsupported ROI types
    • Explicit dynamic ROI limitation notice

@ConvolutedDog
Copy link
Contributor Author

ConvolutedDog commented Jul 12, 2025

@mshr-h Request a review.

mshr-h
mshr-h approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@mshr-h mshr-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mshr-h mshr-h merged commit a61e3ca into apache:main Jul 14, 2025
10 checks passed
@ConvolutedDog ConvolutedDog mentioned this pull request Jul 14, 2025
Merged
ConvolutedDog added a commit to ConvolutedDog/tvm that referenced this pull request Jul 14, 2025
@ConvolutedDog
[Upstream] Collection of PRs megered to upstream
3180e57 
- apache#18145
- apache#18144
- apache#18143
- apache#18138
- apache#18137
ShiboXing pushed a commit to ShiboXing/tvm that referenced this pull request Aug 10, 2025
@ConvolutedDog @ShiboXing
[Fix][ONNX] Fixed constant ROI handling in resize2d when loading onnx…
7d834c3 
… models (apache#18138)

* Fix onnx resize2d

* Fix onnx resize2d

* Fix onnx resize2d

* Add more roi cases for unittest
@ysh329 ysh329 mentioned this pull request Oct 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshr-h mshr-h mshr-h approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Error converting operator Resize: Mismatched type on argument

2 participants

@ConvolutedDog @mshr-h