Remove IRModule Dependency from Target #15511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
yongwww
force-pushed
the
remove_module_dep_on_target
branch
from
1c60062 to
e696b34
Compare
include/tvm/relay/transform.h
Outdated
| * \param target Target to filter on or retrieve arguments from | ||
| * \return Runtime Module containing compiled functions | ||
| */ | ||
| using FTVMTIRToRuntime = tvm::runtime::TypedPackedFunc<runtime::Module(IRModule, Target)>; |
Contributor
There was a problem hiding this comment.
I think the FTVMTIRToRuntime definition should be in include/tvm/tir/transform.h instead.
Member
Author
There was a problem hiding this comment.
Thanks for the inputs! I changed the code to directly use "using FTVMTIRToRuntime = tvm::runtime::TypedPackedFunc<runtime::Module(IRModule, Target)>;" in target.cc & codegen.cc.
ekalda
reviewed
Aug 10, 2023
yongwww
force-pushed
the
remove_module_dep_on_target
branch
from
ddd9168 to
0e268d1
Compare
kparzysz-quic
approved these changes
Aug 10, 2023
Member
Author
|
cc: @tqchen @junrushao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a dependency of IRModule in the current Target implementation:
target.h -> module.h. This pull request aims to decouple the dependency."