-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[CMSIS-NN] Support for Softmax Int16 operator #15407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nikeran
commented
Jul 25, 2023
- Support for int16 Softmax in CMSIS-NN
- Supporting integration test
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
1567dae to
17b6616
Compare
|
cc @lhutton1 |
lhutton1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Nikeran this looks great, thanks for the hard work on it! I had mostly stylistic changes and one comment that might be a bit more involved - happy to go through it separately
Aleksei-grovety
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Nikeran! Looks good just a couple questions.
* Addressed comments regarding PR including modifying the way in which the number the constant buffers shape and number of bits are extracted
|
@lhutton1 would you take a look at the update to see if you find anything that needs changing? |
lhutton1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thanks @Nikeran @Aleksei-grovety @ashutosh-arm! |