Skip to content

Conversation

@Nikeran
Copy link
Contributor

@Nikeran Nikeran commented Jul 25, 2023

  • Support for int16 Softmax in CMSIS-NN
  • Supporting integration test

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jul 25, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Nikeran Nikeran force-pushed the CMSIS_NN_Softmax_Int16_support branch from 1567dae to 17b6616 Compare July 27, 2023 15:56
@asparkhi
Copy link
Contributor

cc @lhutton1

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nikeran this looks great, thanks for the hard work on it! I had mostly stylistic changes and one comment that might be a bit more involved - happy to go through it separately

Copy link
Contributor

@Aleksei-grovety Aleksei-grovety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nikeran! Looks good just a couple questions.

* Addressed comments regarding PR including modifying the way in which the number the constant buffers shape and number of bits are extracted
@Nikeran
Copy link
Contributor Author

Nikeran commented Aug 8, 2023

@lhutton1 would you take a look at the update to see if you find anything that needs changing?

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhutton1 lhutton1 merged commit 77b71fc into apache:main Aug 9, 2023
@lhutton1
Copy link
Contributor

lhutton1 commented Aug 9, 2023

Thanks @Nikeran @Aleksei-grovety @ashutosh-arm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants