-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[topi] Add arm_cpu specific pooling schedules
#15311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
This is the same commit as in #14855 (credit to @FranklandJack). It was reverted by #15286, although, after efforts to reproduce the failure mentioned in the PR, I've not been successful. In addition, the patch is rebased and passing CI. Happy to try to correct the import issue if there is a reproducer (cc @junrushao) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @lhutton1!
Leaving this open so that others have opportunity to comment.
This commit: * Adds specialized `arm_cpu` pooling schedules for both fixed width and salable vectors. * Enables topi testing of new `arm_cpu` schedules. Co-authored-by: Jack Frankland <[email protected]> Change-Id: Ib07fb438ba9ee8ab92fc5bfc438479959411e7db
2554420 to
776648e
Compare
Change-Id: I7e4af0fd7aa8c09fb44248efd3761963730057e8
|
We're still seeing a circular import: |
This is an attempt to fix the circular import referenced in apache#15311 (comment). The stack trace reports an import that was introduced as part of this change: from ....topi.arm_cpu.mprofile import dsp`. The fix is make the import absolute rather than relative. Change-Id: I2fc2923bfe547359a1216b106fff217b6add7374
This reverts commit 0a3ad64.
|
Thanks for reporting @kparzysz-quic, do you have a reproducer so I can take a look? |
|
It came up in our automated tests, but I'll try to get you something. |
|
The same error. Can reproduce it by PS: my python version is Py 3.9. |
|
Thanks @Hzfengsy, I'll take a look |
This commit:
arm_cpupooling schedules for both fixed width and salable vectors.arm_cpuschedules.cc @neildhickey @ekalda @FranklandJack