[TIR] Call TVMBackendFreeWorkspace inside LetStmt #15253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the call to `TVMBackendFreeWorkspace` occurred outside the `LetStmt` that defined the workspace pointer. While works with current codegen, as the code produced for `LetStmt` does not check for out-of-scope access, this access of an out-of-scope should be avoided. This commit updates `LowerTVMBuiltin` to produce the call to `TVMBackendFreeWorkspace` at the end of the `LetStmt`'s body, rather than just after the `LetStmt`.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Prior to this commit, the `AttrStmt` providing the storage alignment was placed outside the `LetStmt` that defines the variable. As a result, the alignment assumption is never actually used, as `CodeGenLLVM::VisitStmt_(const AttrStmtNode*)` only creates an alignment assumption for in-scope variables. This commit moves the storage alignment `AttrStmt` to be inside the `LetStmt`, rather than outside.
Lunderberg
force-pushed
the
lower_tvm_builtin_free_inside_letstmt
branch
from
00749e6 to
1a0fe67
Compare
Hzfengsy
approved these changes
Jul 10, 2023
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 24, 2023
* [TIR] Call TVMBackendFreeWorkspace inside LetStmt Prior to this commit, the call to `TVMBackendFreeWorkspace` occurred outside the `LetStmt` that defined the workspace pointer. While works with current codegen, as the code produced for `LetStmt` does not check for out-of-scope access, this access of an out-of-scope should be avoided. This commit updates `LowerTVMBuiltin` to produce the call to `TVMBackendFreeWorkspace` at the end of the `LetStmt`'s body, rather than just after the `LetStmt`. * [TIR] Output AttrStmt "storage_alignment" inside the var binding Prior to this commit, the `AttrStmt` providing the storage alignment was placed outside the `LetStmt` that defines the variable. As a result, the alignment assumption is never actually used, as `CodeGenLLVM::VisitStmt_(const AttrStmtNode*)` only creates an alignment assumption for in-scope variables. This commit moves the storage alignment `AttrStmt` to be inside the `LetStmt`, rather than outside.
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 27, 2023
* [TIR] Call TVMBackendFreeWorkspace inside LetStmt Prior to this commit, the call to `TVMBackendFreeWorkspace` occurred outside the `LetStmt` that defined the workspace pointer. While works with current codegen, as the code produced for `LetStmt` does not check for out-of-scope access, this access of an out-of-scope should be avoided. This commit updates `LowerTVMBuiltin` to produce the call to `TVMBackendFreeWorkspace` at the end of the `LetStmt`'s body, rather than just after the `LetStmt`. * [TIR] Output AttrStmt "storage_alignment" inside the var binding Prior to this commit, the `AttrStmt` providing the storage alignment was placed outside the `LetStmt` that defines the variable. As a result, the alignment assumption is never actually used, as `CodeGenLLVM::VisitStmt_(const AttrStmtNode*)` only creates an alignment assumption for in-scope variables. This commit moves the storage alignment `AttrStmt` to be inside the `LetStmt`, rather than outside.
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 30, 2023
* [TIR] Call TVMBackendFreeWorkspace inside LetStmt Prior to this commit, the call to `TVMBackendFreeWorkspace` occurred outside the `LetStmt` that defined the workspace pointer. While works with current codegen, as the code produced for `LetStmt` does not check for out-of-scope access, this access of an out-of-scope should be avoided. This commit updates `LowerTVMBuiltin` to produce the call to `TVMBackendFreeWorkspace` at the end of the `LetStmt`'s body, rather than just after the `LetStmt`. * [TIR] Output AttrStmt "storage_alignment" inside the var binding Prior to this commit, the `AttrStmt` providing the storage alignment was placed outside the `LetStmt` that defines the variable. As a result, the alignment assumption is never actually used, as `CodeGenLLVM::VisitStmt_(const AttrStmtNode*)` only creates an alignment assumption for in-scope variables. This commit moves the storage alignment `AttrStmt` to be inside the `LetStmt`, rather than outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the call to
TVMBackendFreeWorkspaceoccurred outside theLetStmtthat defined the workspace pointer. While works with current codegen, as the code produced forLetStmtdoes not check for out-of-scope access, this access of an out-of-scope should be avoided.In addition, the
AttrStmtproviding the storage alignment was placed outside theLetStmtthat defines the variable. As a result, the alignment assumption is never actually used, asCodeGenLLVM::VisitStmt_(const AttrStmtNode*)only creates an alignment assumption for in-scope variables.This PR updates
LowerTVMBuiltinto produce both the storage alignmentAttrStmtand the call toTVMBackendFreeWorkspaceinside the body ofLetStmt, rather than outside.