Skip to content

Conversation

@vincentccc
Copy link
Contributor

@vincentccc vincentccc commented Jun 21, 2023

support to set specific xgboost tree method

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jun 21, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@zxybazh
Copy link
Member

zxybazh commented Jul 18, 2023

@tvm-bot rerun

@zxybazh zxybazh self-assigned this Jul 18, 2023
Copy link
Member

@zxybazh zxybazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the new tree method option! Generally looks ok to me, would you please fix the typos and some docs as commented?

@vincentccc vincentccc force-pushed the support_set_tree_method branch from 0c68ad2 to 2245123 Compare July 26, 2023 06:57
Copy link
Member

@zxybazh zxybazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@zxybazh zxybazh merged commit d1f7ef4 into apache:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants