build(be/deps): replace importlib_metadata usage with native Python 3.10+ importlib.metadata
#33868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33868 +/- ##
===========================================
+ Coverage 60.48% 72.88% +12.39%
===========================================
Files 1931 559 -1372
Lines 76236 40402 -35834
Branches 8568 4245 -4323
===========================================
- Hits 46114 29448 -16666
+ Misses 28017 9857 -18160
+ Partials 2105 1097 -1008
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dosubot
bot
added
change:backend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Missing Python Version Compatibility Check ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/db_engine_specs/init.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| import pkgutil | ||
| from collections import defaultdict | ||
| from importlib import import_module | ||
| from importlib.metadata import entry_points |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
hainenber
changed the title
importlib_metadata usageimportlib_metadata usage with native Python 3.10+ importlib.metadata
amaannawab923
added a commit
to amaannawab923/superset
that referenced
this pull request
Jun 24, 2025
* fix(logo): fix logo url typo (apache#33867) * chore(Icons): Add UsergroupAddOutlined icon (apache#33866) * fix(api): Added uuid as a valid search column (apache#33833) * fix(native filters): Make the Apply button available after click on Clear All (apache#33834) * build(deps): remove legacy browser polyfills (apache#33853) Signed-off-by: hainenber <[email protected]> * build(dev-deps): update `fetch-mock` to v11 (apache#33854) Signed-off-by: hainenber <[email protected]> * build(be/deps): replace `importlib_metadata` usage with native Python 3.10+ `importlib.metadata` (apache#33868) Signed-off-by: hainenber <[email protected]> * chore: Updates files related to 5.0.0 release (apache#33869) * chore(docs): bump references to docker image versions upon release of 5.0.0 (apache#33872) --------- Signed-off-by: hainenber <[email protected]> Co-authored-by: Levis Mbote <[email protected]> Co-authored-by: Enzo Martellucci <[email protected]> Co-authored-by: Paul Rhodes <[email protected]> Co-authored-by: Vitor Avila <[email protected]> Co-authored-by: Đỗ Trọng Hải <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Sam Firke <[email protected]>
LisaHusband
pushed a commit
to LisaHusband/superset
that referenced
this pull request
Jun 28, 2025
… 3.10+ `importlib.metadata` (apache#33868) Signed-off-by: hainenber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Closes #33801
Migrate
importlib-metadatausage to built-inimportlib.metadatamodule in Python 3.10+ since the project no longer support Python 3.9, required as workaround in the past.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION