fix: allow metadata to parse json #33444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Inefficient Empty Object Check ▹ view | 🧠 Incorrect |
 |
Nested ternary making value assignment hard to read ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| width="100%" | ||
| height="160px" | ||
| value={ | ||
| !Object.keys(extraJson?.metadata_params || {}).length |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
534
to
540
| value={ | ||
| !Object.keys(extraJson?.metadata_params || {}).length | ||
| ? '' | ||
| : extraJson?.metadata_params | ||
| : typeof extraJson?.metadata_params === 'string' | ||
| ? extraJson?.metadata_params | ||
| : JSON.stringify(extraJson?.metadata_params) | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
eschutho
force-pushed
the
elizabeth/metadata-bug
branch
from
6546b2e to
89db23f
Compare
eschutho
force-pushed
the
elizabeth/metadata-bug
branch
from
89db23f to
9b0e180
Compare
betodealmeida
approved these changes
May 15, 2025
|
@eschutho Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments |
|
@eschutho Ephemeral environment spinning up at http://54.191.220.223:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
michael-s-molina
added
the
v5.0
michael-s-molina
pushed a commit
that referenced
this pull request
May 23, 2025
(cherry picked from commit b050897)
LevisNgigi
pushed a commit
to LevisNgigi/superset
that referenced
this pull request
Jun 18, 2025
alexandrusoare
pushed a commit
to alexandrusoare/superset
that referenced
this pull request
Jun 19, 2025
(cherry picked from commit b050897)
mistercrunch
added
🍒 5.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When editing in the Metadata Parameters in the database editor, if possible, we parse the string to a javascript object, but were not converting it back to a string in order for the ace editor to display the text, resulting in an error.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TESTING INSTRUCTIONS
edit the metadata parameters and save, reload the database
ADDITIONAL INFORMATION