Skip to content

Conversation

@linghengqian
Copy link
Member

@linghengqian linghengqian commented Oct 12, 2024

For #32927.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian marked this pull request as ready for review October 12, 2024 14:07
Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • CC @RaigorJiang . Also for #33025 (comment) .
  • A bit strange, it seems that only Oracle JDK's JDK 17.0.11, 11.0.23, 8u411 supports parsing the JVM argument of -proc:full. I added a separate Maven Profile to verify ./mvnw clean package -f examples/pom.xml -T1C.

Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I used GraalVM CE For JDK 23 to complete the verification of ./mvnw clean install -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e and ./mvnw clean package -f examples/pom.xml -T1C.

@linghengqian linghengqian marked this pull request as ready for review October 12, 2024 14:52
@yx9o yx9o merged commit a7244f8 into apache:master Oct 12, 2024
141 checks passed
@linghengqian linghengqian added this to the 5.5.1 milestone Oct 12, 2024
@linghengqian linghengqian deleted the jdk23 branch October 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants