add epoch to handle create producer timeout #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Aug 6, 2021
cckellogg
reviewed
Aug 6, 2021
|
@cckellogg thanks for your comments, I have addressed your comments in the latest commit, PTAL when you have time. |
cckellogg
reviewed
Aug 9, 2021
cckellogg
reviewed
Aug 9, 2021
merlimat
approved these changes
Aug 10, 2021
cckellogg
approved these changes
Aug 10, 2021
zzzming
pushed a commit
to datastax/pulsar-client-go
that referenced
this pull request
Dec 22, 2021
* add epoch to producer * fix CI * address comments * address comments * update style * better logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: apache/pulsar#5606
Motivation
Handle create producer timeout on pulsar-client-go. To prevent duplicate producer when broker is not available.
Modifications
epochtopartitionProduceruserProvidedProducerNametopartitionProducerVerifying this change