Skip to content

Fix:The producer is sometimes blocked when calling producer.SendAsync #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix:The producer is sometimes blocked when calling producer.SendAsync #1366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5548abb
fixbug: don't repeated call cb when producer is closed
idehong May 13, 2025
5b36744
fixbug: don't repeated call cb when producer is closed
idehong May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pulsar/producer_partition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,6 +1475,14 @@ func (p *partitionProducer) failPendingMessages(err error) {
if viewSize <= 0 {
return
}

// fixbug: don't repeated call cb when producer is closed
// the cb funciton is calling by pi.sendRequests.done
state := p.getProducerState()
if state == producerClosing || state == producerClosed {
return
}

p.log.Infof("Failing %d messages on closing producer", viewSize)
lastViewItem := curViewItems[viewSize-1].(*pendingItem)

Expand Down