(#2890) - reduce md5 chunk size to 32768 #2897
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hardly a slam dunk, but by reducing the md5 chunk size, it seems to me to block DOM rendering much less than before.
In these videos I'm loading some large-ish GIFs wholesale into WebSQL in a WebView on a Nexus 5 running Android 4.4.4. The Blobs are provided via xhr with
xhr.responseType = 'arraybuffer', thennew Blob().Before 1, After 1
Before 2, After 2
The DOM is still obviously getting blocked, because the GIFs freeze, but they seem to freeze a bit less when the chunk size is lower. But even if it's just my imagination, can we agree that 32KB is a more reasonable default than 500KB in browsers? Or that maybe we should make this configurable?