Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Mar 17, 2025

Bump to Resolver 2.0.8, changes:

  • updates Maven to Resolver 2.0.8
  • implements maven specific validator (new in Resolver 2.0.8)
  • applies required changes to suppliers

Note: Requires Resolver 2.0.8 release.


https://issues.apache.org/jira/browse/MNG-8677

@cstamas
Copy link
Member Author

cstamas commented Mar 21, 2025

Validator now catches same ITs as Mimir (due bug) in this PR #2176
But there is +1 IT as well, that seems to tries to use un-interpolated remote repo.

cstamas added a commit that referenced this pull request Mar 27, 2025
…d un-interpolated (#2192)

This PR contains @gnodet fix pulled out from #2158 and added a rudimentary and very ugly test.

The original PR is unrelated, but did catch this "leak" of uniterpolated values.

---

https://issues.apache.org/jira/browse/MNG-8629
@cstamas cstamas closed this Mar 27, 2025
@cstamas cstamas deleted the MRESOLVER-687 branch March 27, 2025 14:21
@cstamas cstamas restored the MRESOLVER-687 branch March 27, 2025 14:22
@cstamas cstamas reopened this Mar 27, 2025
@cstamas
Copy link
Member Author

cstamas commented Mar 27, 2025

One IT failure:

  • MavenITmng5639ImportScopePomResolutionTest.testitMNG5639

@gnodet
Copy link
Contributor

gnodet commented Mar 28, 2025

One IT failure:

  • MavenITmng5639ImportScopePomResolutionTest.testitMNG5639

The test looks weird to me. The user settings contain a repository with a url containing a property substitution for which the value is defined in the pom properties. I think it would be ok if the property was defined as a Maven user property from CLI.

I'd refactor the test to add a file .mvn/maven.properties containing:

repository.url.suffix.property = repo-set-by-property

and remove that property from the pom. As settings are interpolated, it seems to work.
In addition we should validate that settings repositories do not contain any properties anymore I think.

@cstamas cstamas added this to the 4.0.0-rc-4 milestone Apr 3, 2025
@cstamas cstamas marked this pull request as ready for review April 3, 2025 15:14
@cstamas cstamas requested a review from gnodet April 3, 2025 15:30
@cstamas cstamas changed the title [MRESOLVER-687] Adding Maven Validator [MNG-8677] Bump to Resolver 2.0.8 and more Apr 4, 2025
@cstamas cstamas merged commit c7f22fe into apache:master Apr 12, 2025
13 checks passed
@cstamas cstamas deleted the MRESOLVER-687 branch April 12, 2025 07:11
@Bukama Bukama added dependencies Pull requests that update a dependency file and removed maintenance labels Jun 19, 2025
@jira-importer
Copy link

Resolve #9631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants