-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
Milestone
Description
Tamas Cservenak opened MNG-8646 and commented
As it turned out, ITs were not using Mimir as they redefined Maven Central to allow snapshots, and that made Mimir not handle the IT used Maven Central (while those did not contain snapshots, it was still pointing at canonical Maven Central URL).
Fixing this revealed several other (related or unrelated) issues:
- MavenProject was NPE prone regarding remote repositories handling
- MappedList was NPE prone regarding null values (emitted by MavenProject remote repositories)
- several ProjectModelBuilder (detailed below) had no remote repositories set anymore (as central is not in super POM anymore)
- some ITs revaled ReactorReader issues as well
org.apache.maven.project.DefaultProjectBuilder issues:
- model request type CONSUMER_PARENT is used for non-locally built projects (ie. plugins invoked with direct mojo invocation), this seems strange. This skips CI friendly replacement for example as shows in Maven ITs
- remote repositories are injected ONLY when injecting lifecycle plugins (processPlugins=true). This was ok when root pom was defining default repository, but that's not the case anymore, and this results in projects built that has 0 remote reposes.
At the end of the day, all issues were fixed but one IT that we declared "invalid" was disabled (w/ remark about why's).
Issue Links:
- MNG-8625 Project builder w/ CI friendly versions: tries to resolve un-interpolated versioned artifacts
("fixes")
Remote Links: