Skip to content

[MRESOLVER-85] Cast ByteBuffer to Byte for JDK8 support #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MRESOLVER-85] Cast ByteBuffer to Byte for JDK8 support #32

wants to merge 2 commits into from

Conversation

slachiewicz
Copy link
Member

No description provided.

michael-o
michael-o requested changes Apr 12, 2019
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all ITs pass with Java 8 and 11?

michael-o
michael-o reviewed Apr 12, 2019
View reviewed changes
.travis.yml

script:
- mvn verify
- mvn -V -P+run-its clean verify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+run-its?

@slachiewicz
[MRESOLVER-85] Cast ByteBuffer to Byte for JDK8 support
1ef6881 
Explicit cast for compatibility with covariant return type on JDK 9's ByteBuffer
@slachiewicz
Sync Travis CI build config with ASF Jenkins - run with -Prun-its pro…
819a8be 
…file
@slachiewicz
Copy link
Member Author

I don't have rights to push to maven-resolver branch to run in ASF Jenkins, but all test passed locally with Java 12.
Also, tests running on Linux with Travis CI - passed without issues for OpenJDK 7, 8, 11, 12.

https://travis-ci.org/slachiewicz/maven-resolver/builds/519294192

@michael-o
Copy link
Member

This is wrong, you should be able to do so. Can you raise this on the dev list?

@slachiewicz
Copy link
Member Author

run-its - i used the value from command line in latest Jenkins build log.

[Pipeline] bat
Commit message: "[MRESOLVER-7] Download dependency POMs in parallel"

f:\jenkins\jenkins-slave\workspace\maven-box_maven-resolver_master\m>mvn -P+run-its -Dmaven.test.failure.ignore=true -Dfindbugs.failOnError=false -Dfindbugs.skip=true clean verify
----- withMaven Wrapper script -----

f:\jenkins\jenkins-slave\workspace\maven-box_maven-resolver_master@2\m>mvn -P+run-its -Dmaven.test.failure.ignore=true -Dfindbugs.failOnError=false -Dfindbugs.skip=true clean verify
----- withMaven Wrapper script -----
Cleaning workspace
git clean -fdx # timeout=10
Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
Maven home: F:\jenkins\tools\maven\apache-maven-3.5.2\bin..

@michael-o
Copy link
Member

That's nonsense, look into the POM. There is no such profile.

@slachiewicz
Copy link
Member Author

That's nonsense, look into the POM. There is no such profile.

But you asked to run its :)

here is profile..
https://github.com/apache/maven-resolver/blob/master/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml#L87

@michael-o
Copy link
Member

Indeed, but the + is still wrong.

@slachiewicz
Copy link
Member Author

Indeed, but the + is still wrong.

so all our builds should be wrong

https://gitbox.apache.org/repos/asf?p=maven-jenkins-lib.git;a=blob;f=vars/asfMavenTlpStdBuild.groovy;h=8bf4492dd33d5a226ed0f05b549d6f48f20767ad;hb=HEAD#l55

@jira-importer jira-importer mentioned this pull request Apr 18, 2025
Closed
@jira-importer
Copy link

Resolve #826

1 similar comment
@jira-importer
Copy link

Resolve #826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slachiewicz @michael-o @jira-importer