MINOR Metrics: use String.intern() to reduce duplicate metric names and tags #20328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
changed the title
…nd tags While diagnosing an out of memory condition, our profiler alerted us that tens of megabytes of our heap was used to store redundant String objects. In particular, the strings `thread_id`, `rocksdb_state_id`, `task_id`, and `org.apache.kafka.consumer.fetch.manager.preferred.read.replica` alone take 12MB. All of these objects are strongly held by MetricKey or MetricName instances. Interning a string is a somewhat expensive operation, however, metric names are generally created once at initialization and then not again dynamically (excepting some per-connection tracking)
stevenschlansker
force-pushed
the
metrics-intern
branch
from
88f79e9 to
2dd6c24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While diagnosing an out of memory condition, our profiler alerted us
that tens of megabytes of our heap was used to store redundant String
objects.
In particular, the strings
thread_id,rocksdb_state_id,task_id,and
org.apache.kafka.consumer.fetch.manager.preferred.read.replicaalone take 12MB. All of these objects are strongly held by MetricKey or
MetricName instances.
Interning a string is a somewhat expensive operation, however, metric
names are generally created once at initialization and then not again
dynamically (excepting some per-connection tracking)