KAFKA-19591 solving issues with gradlew content: an old template version was being referenced
#20327
+23
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
Note: this PR is related to Gradle upgrade from 8 to 9: #19513 (they can be combined into one, but I prefer to keep them separated). |
dejan2609
changed the title
gradlew content: an old template version (i.e. file unixStartScript.txt was being referenced)gradlew content: an old template version (i.e. file unixStartScript.txt) was being referenced
…rsion (i.e. file `unixStartScript.txt`) was being referenced
|
Note: please pardon me for force-pushing (I had to fix commit message typo error). |
|
One check fails (due to PR title being too long); will fix that. |
dejan2609
changed the title
gradlew content: an old template version (i.e. file unixStartScript.txt) was being referencedgradlew content: an old template version was being referenced
|
FYI @apoorvmittal10: this is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding JIRA ticket:
Related PR:
Intro:
unixStartScript.txt(that servers as a template for agradlew) path/module was changed in Gradle version 8.8.0Problem description (for all details see JIRA ticket above):
8.14.1
but thing is that
gradlewis referencing Gradle 8.7.0 templatefile
unixStartScript.txtgradlewis missing all recent changes for a templatefile
unixStartScript.txt(i.e. all the changes that were made aftertemplate file was moved:
https://github.com/gradle/gradle/commits/v8.14.1/platforms/jvm/plugins-application/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt)
Loosely related Gradle Github issue: