KAFKA-18068: Fix the typo PARTITIONER_ADPATIVE_PARTITIONING_ENABLE in ProducerConfig
#20317
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Programmer-RD-AI
approved these changes
Aug 6, 2025
m1a2st
approved these changes
Aug 7, 2025
Rancho-7
approved these changes
Aug 7, 2025
chia7712
reviewed
Aug 7, 2025
| @@ -101,8 +101,10 @@ public class ProducerConfig extends AbstractConfig { | |||
| + "similar or lower producer latency despite the increased linger."; | |||
|
|
|||
| /** <code>partitioner.adaptive.partitioning.enable</code> */ | |||
| public static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable"; | |||
| private static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_DOC = | |||
| public static final String PARTITIONER_ADAPTIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable"; | |||
There was a problem hiding this comment.
this is a minor deprecation, but it doesn't hurt to include it in upgrade.html, right?
There was a problem hiding this comment.
I forgot to update upgrade.html.
#20322 will fix that.
chia7712
pushed a commit
that referenced
this pull request
Aug 7, 2025
…_ENABLE_CONFIG (#20322) Document deprecation of PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG in `upgrade.html`, which was missed in #20317 Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a typo in ProducerConfig: Renames
PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG→PARTITIONER_ADAPTIVE_PARTITIONING_ENABLE_CONFIGThe old key is retained for backward compatibility.
See: KIP-1175: Fix the typo
PARTITIONER_ADPATIVE_PARTITIONING_ENABLEin ProducerConfig
Reviewers: Yung [email protected], TengYao Chi
[email protected], Ken Huang [email protected], Nick Guo
[email protected], Ranuga Disansa [email protected]