ci: add randomized matrix for better test coverage defect, TestElement.contentEquals edition #5727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
ci_random_matrix2
branch
2 times, most recently
from
aaa556c to
6ba12f3
Compare
6 tasks
vlsi
force-pushed
the
ci_random_matrix2
branch
5 times, most recently
from
0c4506d to
33df5c3
Compare
…ment.contentEquals Previously, AbstractTestElement.hashCode used System.identityHashcode, so it was not consistent with equals, and TestElements were often used in HashMap keys. So the fix is to use reference equality in equals, so it becomes consistent with hashCode. AbstractTestElement.equals is marked deprecated because so the clients could adjust their code if they really need compare the contents of the TestElements rather than references.
__changeCase uses java-default locale, so the test does not support tr_TR locale. See apache#5723
…tions are workable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation for #693
The key difference is that I create
TestElement.contentEqualsand markTestElement.equalsdeprecated.