-
Notifications
You must be signed in to change notification settings - Fork 180
HBASE-26863 fix incorrect rowkey pushdown #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
re-trigger the QA |
Reidddddd
requested changes
Aug 3, 2023
spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/DefaultSource.scala
Outdated
Show resolved
Hide resolved
Reidddddd
reviewed
Aug 3, 2023
spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/DefaultSource.scala
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Reidddddd
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
subrat-mishra
pushed a commit
to subrat-mishra/hbase-connectors
that referenced
this pull request
Aug 8, 2023
Signed-off-by: Reid Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incorrect rowkey pushdown caused by miscalculation of overlapping scan ranges, which occurs when spark sql optimizer generates pushdown filters in such an order that a scan range that comes later overshadows the previous scan range.