Skip to content

Conversation

@morokosi
Copy link
Contributor

@morokosi morokosi commented Mar 28, 2022

This PR fixes an incorrect rowkey pushdown caused by miscalculation of overlapping scan ranges, which occurs when spark sql optimizer generates pushdown filters in such an order that a scan range that comes later overshadows the previous scan range.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 18s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 1m 31s master passed
+1 💚 compile 0m 37s master passed
+1 💚 scaladoc 0m 45s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 47s the patch passed
+1 💚 compile 0m 38s the patch passed
+1 💚 scalac 0m 38s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 scaladoc 0m 45s the patch passed
_ Other Tests _
+1 💚 unit 7m 31s hbase-spark in the patch passed.
14m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #95
Optional Tests dupname scalac scaladoc unit compile
uname Linux 29c351fdbd06 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 036729d
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/1/testReport/
Max. process+thread count 919 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/1/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 3m 54s master passed
+1 💚 compile 0m 39s master passed
+1 💚 scaladoc 0m 51s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 45s the patch passed
+1 💚 compile 0m 38s the patch passed
+1 💚 scalac 0m 38s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 scaladoc 0m 46s the patch passed
_ Other Tests _
+1 💚 unit 7m 30s hbase-spark in the patch passed.
16m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #95
Optional Tests dupname scalac scaladoc unit compile
uname Linux 736588c6b0e3 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 036729d
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/2/testReport/
Max. process+thread count 919 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/2/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Reidddddd
Copy link

re-trigger the QA

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 1m 35s master passed
+1 💚 compile 0m 38s master passed
+1 💚 scaladoc 0m 46s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 45s the patch passed
+1 💚 compile 0m 38s the patch passed
+1 💚 scalac 0m 38s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 scaladoc 0m 47s the patch passed
_ Other Tests _
+1 💚 unit 8m 11s hbase-spark in the patch passed.
15m 23s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #95
Optional Tests dupname scalac scaladoc unit compile
uname Linux 31868f6bcbef 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / f8ee8f6
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/3/testReport/
Max. process+thread count 948 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/3/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@morokosi morokosi requested a review from Reidddddd August 3, 2023 12:08
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 1s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 1m 43s master passed
+1 💚 compile 0m 38s master passed
+1 💚 scaladoc 0m 49s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 46s the patch passed
+1 💚 compile 0m 37s the patch passed
+1 💚 scalac 0m 37s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 scaladoc 0m 48s the patch passed
_ Other Tests _
+1 💚 unit 8m 26s hbase-spark in the patch passed.
14m 58s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/4/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #95
Optional Tests dupname scalac scaladoc unit compile
uname Linux 06816fe10142 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / f8ee8f6
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/4/testReport/
Max. process+thread count 955 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-95/4/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link

@Reidddddd Reidddddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Reidddddd Reidddddd merged commit 4b81148 into apache:master Aug 4, 2023
subrat-mishra pushed a commit to subrat-mishra/hbase-connectors that referenced this pull request Aug 8, 2023
@morokosi morokosi deleted the HBASE-26863 branch August 16, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants