HBASE-27883: Use log4j2 instead of log4j for logging.

[subrat-mishra]

No description provided.

[Reidddddd]

re-trigger the check

[Reidddddd]

+1

[Reidddddd]

emm, hold on

just checked the code base, it seems using slf4j not apache logging...

Need double checks

[subrat-mishra]

re-trigger the check

[subrat-mishra]

@Reidddddd, could you please take a look at it? I have removed slf4j-log4j12 from hbase-spark/pom.xml and also the transitive dependencies as well. Is it fine now?

[Reidddddd]

ping @petersomogyi, would you like to give a review as well

[Reidddddd]

@subrat-mishra there are places i don't understand, could you explain them to me

1. why replace log4j with org.apache.logging.log4j
2. and org.apache.logging.log4j is still log4j not log4j2? seems not as title describes

[petersomogyi]

1. why replace log4j with org.apache.logging.log4j

That is the groupId for log4j2, check these dependencies for the hbase repository: https://github.com/apache/hbase/blob/master/pom.xml#L1340-L1359

2. and org.apache.logging.log4j is still log4j not log4j2? seems not as title describes

org.apache.logging.log4j is with version 2.17.2, so it is log4j2.

[petersomogyi]

Should the org.slf4j dependencies be updated? For example slf4j-log4j12 is binding/provider for log4j version 1.2, shouldn't be needed anymore.
SLF4J dependencies in hbase: https://github.com/apache/hbase/blob/master/pom.xml#L1325-L1339

[subrat-mishra]

Should the org.slf4j dependencies be updated? For example slf4j-log4j12 is binding/provider for log4j version 1.2, shouldn't be needed anymore. SLF4J dependencies in hbase: https://github.com/apache/hbase/blob/master/pom.xml#L1325-L1339

Thanks @petersomogyi, for pointing that out. I missed removing slf4j-log4j12 from parent pom.xml

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	1m 20s	master passed
+1 💚	compile	0m 52s	master passed
+1 💚	javadoc	0m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 49s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 49s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 3s	root in the patch passed.
		15m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/6/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#117
Optional Tests	dupname javac javadoc unit xml compile
uname	Linux 6de5c9c68dab 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux
Build tool	hb_maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / bfcdf68
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/6/testReport/
Max. process+thread count	936 (vs. ulimit of 12500)
modules	C: kafka/hbase-kafka-proxy spark/hbase-spark spark/hbase-spark-it . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/6/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Reidddddd]

That is the groupId for log4j2, check these dependencies for the hbase repository: https://github.com/apache/hbase/blob/master/pom.xml#L1340-L1359

not familiar with these parts, thanks for explanation