Add configuration options to control table creation restrictions #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuchong
reviewed
Aug 10, 2025
There was a problem hiding this comment.
Thanks @platinumhamburg for contribution.
Please add tests for this feature (e.g., in FlussAdminITCase or TableManagerITCase). Besides, please add documentation for the new configs.
| @@ -1309,6 +1309,24 @@ public class ConfigOptions { | |||
| "The column name of the version column for the `versioned` merge engine. " | |||
| + "If the merge engine is set to `versioned`, the version column must be set."); | |||
|
|
|||
| public static final ConfigOption<Boolean> LOG_TABLE_ALLOW_CREATION = | |||
| key("log.table.allow-creation") | |||
There was a problem hiding this comment.
How about allow.create.log.tables and allow.create.kv.tables? This makes sure both of them be able to be together on docs when we support auto generate docs in the future.
And please put the ConfigOptions after AUTO_PARTITION_CHECK_INTERVAL? Because table.* are table-level configs, not server-side configs.
Comment on lines
+677
to
+679
| "Creation of KV tables (primary key tables) is not allowed. " | ||
| + "Table: %s. Please set '%s' to true to enable KV table creation.", | ||
| tablePath, ConfigOptions.KV_TABLE_ALLOW_CREATION.key())); |
There was a problem hiding this comment.
Suggested change
| "Creation of KV tables (primary key tables) is not allowed. " | |
| + "Table: %s. Please set '%s' to true to enable KV table creation.", | |
| tablePath, ConfigOptions.KV_TABLE_ALLOW_CREATION.key())); | |
| "Creation of Primary Key Tables is disallowed in the cluster."); |
- Use
Primary Key Tablefor user-facing messages, we don't have the concept of KV table actually. - remove the cluster config from the exception message, because user shouldn't be aware of the cluster config and usually don't have the permission to access cluster configs (so it's not necessary to expose them).
Comment on lines
+684
to
+688
| throw new InvalidTableException( | ||
| String.format( | ||
| "Creation of Log tables is not allowed. " | ||
| + "Table: %s. Please set '%s' to true to enable Log table creation.", | ||
| tablePath, ConfigOptions.LOG_TABLE_ALLOW_CREATION.key())); |
There was a problem hiding this comment.
ditto
Suggested change
| throw new InvalidTableException( | |
| String.format( | |
| "Creation of Log tables is not allowed. " | |
| + "Table: %s. Please set '%s' to true to enable Log table creation.", | |
| tablePath, ConfigOptions.LOG_TABLE_ALLOW_CREATION.key())); | |
| throw new InvalidTableException( | |
| "Creation of Log Tables is disallowed in the cluster."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1502
Brief change log
Tests
API and Format
Documentation