Skip to content

Conversation

@bengbengbalabalabeng
Copy link

@bengbengbalabalabeng bengbengbalabalabeng commented Nov 5, 2025

Purpose of the pull request

Fixed: #676.

What's changed?

  • Corrected the 0-based indexing logic in CsvRow#getCell(int).
  • Add unit test.

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@bengbengbalabalabeng
Copy link
Author

PTAL 😁 @delei

@psxjoy psxjoy added PR: first-time contributor first-time contributor PR: reviewing Currently under active review. labels Nov 12, 2025
@psxjoy
Copy link
Member

psxjoy commented Nov 12, 2025

Please handle conflict files :)

@bengbengbalabalabeng
Copy link
Author

Please handle conflict files :)

Thanks for the feedback! I've resolved the conflict files. 😁

@psxjoy
Copy link
Member

psxjoy commented Nov 17, 2025

Let's run unit-test first:)

@bengbengbalabalabeng
Copy link
Author

Let's run unit-test first:)

All existing CsvRowTest cases passed.
Should I add more coverage, or is there another concern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: first-time contributor first-time contributor PR: reviewing Currently under active review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Off-by-one error in CsvRow#getCell(int)

2 participants