Skip to content

Conversation

@delei
Copy link
Member

@delei delei commented Sep 17, 2025

Purpose of the pull request

Close #571

What's changed?

  • Add shared formula handling logic in CellFormulaTagHandler
  • Introduce new attributes for shared formula in ExcelXmlConstants
  • Update XlsxReadSheetHolder to store shared formula information

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@delei delei changed the title feat: support shared formula in xlsx feat: support shared formulas in xlsx files Sep 17, 2025
@delei delei changed the title feat: support shared formulas in xlsx files feat: support for reading shared formulas in xlsx files Sep 18, 2025
@delei delei marked this pull request as ready for review September 18, 2025 13:28
@alaahong alaahong requested a review from Copilot September 18, 2025 15:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for reading shared formulas in XLSX files, which allows for more efficient storage and processing of repeated formulas across multiple cells.

  • Added shared formula handling logic to track and resolve formula references
  • Introduced new XML attributes for identifying and indexing shared formulas
  • Enhanced XlsxReadSheetHolder to store shared formula mappings

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
CellFormulaTagHandler.java Main implementation for parsing and resolving shared formulas from XML
XlsxReadSheetHolder.java Added storage for shared formula index and mapping
ExcelXmlConstants.java Added constants for shared formula XML attributes
CellDataDataTest.java Added test case for reading formulas from XLSX files
CellDataReadData.java Removed empty comment block

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alaahong
Copy link
Member

celldata_formula_sum.xlsx
how about attached file~

@delei delei marked this pull request as draft September 19, 2025 15:41
@gphwxhq
Copy link

gphwxhq commented Sep 26, 2025

工作簿1.xlsx this file seems like dismatch
file content:
Image
formula in code:
Image

@delei delei closed this by deleting the head repository Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] There is a problem with formula reading

3 participants