-
Notifications
You must be signed in to change notification settings - Fork 445
feat: support for reading shared formulas in xlsx files #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for reading shared formulas in XLSX files, which allows for more efficient storage and processing of repeated formulas across multiple cells.
- Added shared formula handling logic to track and resolve formula references
- Introduced new XML attributes for identifying and indexing shared formulas
- Enhanced XlsxReadSheetHolder to store shared formula mappings
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| CellFormulaTagHandler.java | Main implementation for parsing and resolving shared formulas from XML |
| XlsxReadSheetHolder.java | Added storage for shared formula index and mapping |
| ExcelXmlConstants.java | Added constants for shared formula XML attributes |
| CellDataDataTest.java | Added test case for reading formulas from XLSX files |
| CellDataReadData.java | Removed empty comment block |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fastexcel/src/main/java/cn/idev/excel/analysis/v07/handlers/CellFormulaTagHandler.java
Outdated
Show resolved
Hide resolved
fastexcel/src/main/java/cn/idev/excel/analysis/v07/handlers/CellFormulaTagHandler.java
Outdated
Show resolved
Hide resolved
|
celldata_formula_sum.xlsx |
|
工作簿1.xlsx this file seems like dismatch |


Purpose of the pull request
Close #571
What's changed?
Checklist