Minor: Add new Extended ClickBench benchmark queries #8950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Dandandan / @andygrove I wonder if you would have time to quickly review this PR (mostly docs + 2 queries) so I can run benchmarks on #8849 against main? |
tustvold
approved these changes
Jan 25, 2024
Contributor
Author
|
Thank you @tustvold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part #5472
Rationale for this change
We don't have great benchmark coverage for
COUNT(DISTINCT <String>)where the lengths of the strings are small. This came up as part of #8849What changes are included in this PR?
Are these changes tested?
I tested them manually
Are there any user-facing changes?
No, this is benchmark only