Bg unsafe2 #7446
Closed
Bg unsafe2 #7446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
Contributor
Author
|
Let's reopen if constantly updating the map with new heap indexes becomes to burdensome / expensive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7191.
Rationale for this change
PR #7192 could be faster.
What changes are included in this PR?
Convert the
Vec<>heap into aRawPointerone, so that the map never needs to be updated. I intend to just close this PR for now, but I wanted it on record in case we ever decide to fully optimize this.Are these changes tested?
No
Are there any user-facing changes?
No