Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Apr 21, 2021

Here are suggested issue templates for bugs and features, as well as a PR template that will prompt users to enter the issue that the PR is closing.

@andygrove
Copy link
Member Author

@alamb @jorgecarleitao

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #29 (7183ac7) into master (c365a4f) will increase coverage by 5.42%.
The diff coverage is 82.20%.

❗ Current head 7183ac7 differs from pull request most recent head d1c3d5a. Consider uploading reports for the commit d1c3d5a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   70.41%   75.83%   +5.42%     
==========================================
  Files         123      135      +12     
  Lines       21261    23152    +1891     
==========================================
+ Hits        14970    17557    +2587     
+ Misses       6291     5595     -696     
Impacted Files Coverage Δ
ballista/rust/client/src/context.rs 0.00% <0.00%> (ø)
ballista/rust/core/src/datasource.rs 0.00% <ø> (ø)
ballista/rust/core/src/error.rs 0.00% <ø> (ø)
...sta/rust/core/src/serde/logical_plan/from_proto.rs 40.56% <ø> (+40.56%) ⬆️
...llista/rust/core/src/serde/scheduler/from_proto.rs 0.00% <ø> (ø)
ballista/rust/core/src/serde/scheduler/mod.rs 14.28% <ø> (+14.28%) ⬆️
ballista/rust/core/src/serde/scheduler/to_proto.rs 0.00% <ø> (ø)
datafusion/src/optimizer/projection_push_down.rs 98.66% <ø> (ø)
datafusion/src/physical_plan/hash_utils.rs 100.00% <ø> (+2.89%) ⬆️
datafusion/src/optimizer/constant_folding.rs 91.95% <33.33%> (-0.36%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c365a4f...d1c3d5a. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good stuff @andygrove -- I left some comments on apache/arrow-rs#17 (review) that I think also apply to this one

@andygrove
Copy link
Member Author

Once the templates are applied in arrow-rs I will copy them into this PR

@andygrove
Copy link
Member Author

@alamb This is updated to use the same templates as arrow-rs

@andygrove andygrove merged commit 713ba10 into apache:master Apr 23, 2021
@andygrove andygrove deleted the github-templates branch April 23, 2021 14:18
@houqp houqp added the development-process Related to development process of DataFusion label Jul 29, 2021
andygrove added a commit that referenced this pull request Jan 12, 2023
* Initial commit

* initial commit

* failing test

* table scan projection

* closer

* test passes, with some hacks

* use DataFrame (#2)

* update README

* update dependency

* code cleanup (#3)

* Add support for Filter operator and BinaryOp expressions (#4)

* GitHub action (#5)

* Split code into producer and consumer modules (#6)

* Support more functions and scalar types (#7)

* Use substrait 0.1 and datafusion 8.0 (#8)

* use substrait 0.1

* use datafusion 8.0

* update datafusion to 10.0 and substrait to 0.2 (#11)

* Add basic join support (#12)

* Added fetch support (#23)

Added fetch to consumer

Added limit to producer

Added unit tests for limit

Added roundtrip_fill_none() for testing when None input can be converted to 0

Update src/consumer.rs

Co-authored-by: Andy Grove <[email protected]>

Co-authored-by: Andy Grove <[email protected]>

* Upgrade to DataFusion 13.0.0 (#25)

* Add sort consumer and producer (#24)

Add consumer

Add producer and test

Modified error string

* Add serializer/deserializer (#26)

* Add plan and function extension support (#27)

* Add plan and function extension support

* Removed unwraps

* Implement GROUP BY (#28)

* Add consumer, producer and tests for aggregate relation

Change function extension registration from absolute to relative anchor
(reference)

Remove operator to/from reference

* Fixed function registration bug

* Add test

* Addressed PR comments

* Changed field reference from mask to direct reference (#29)

* Changed field reference from masked reference to direct reference

* Handle unsupported case (struct with child)

* Handle SubqueryAlias (#30)

Fixed aggregate function register bug

* Add support for SELECT DISTINCT (#31)

Add test case

* Implement BETWEEN (#32)

* Add case (#33)

* Implement CASE WHEN

* Add more case to test

* Addressed comments

* feat: support explicit catalog/schema names in ReadRel (#34)

* feat: support explicit catalog/schema names in ReadRel

Signed-off-by: Ruihang Xia <[email protected]>

* fix: use re-exported expr crate

Signed-off-by: Ruihang Xia <[email protected]>

Signed-off-by: Ruihang Xia <[email protected]>

* move files to subfolder

* RAT

* remove rust.yaml

* revert .gitignore changes

* tomlfmt

* tomlfmt

Signed-off-by: Ruihang Xia <[email protected]>
Co-authored-by: Daniël Heres <[email protected]>
Co-authored-by: JanKaul <[email protected]>
Co-authored-by: nseekhao <[email protected]>
Co-authored-by: Ruihang Xia <[email protected]>
alamb added a commit that referenced this pull request May 21, 2025
…fig (#16080)

* fix

* add a test

* fmt

* add to upgrade guide

* fix tests

* fix test

* fix test

* fix ci

* Fix example in upgrade guide (#29)

---------

Co-authored-by: Andrew Lamb <[email protected]>
alexanderbianchi pushed a commit to alexanderbianchi/datafusion that referenced this pull request Jul 31, 2025
gabotechs added a commit to gabotechs/datafusion that referenced this pull request Aug 4, 2025
gabotechs added a commit to gabotechs/datafusion that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants