Skip to content

Conversation

@CuteChuanChuan
Copy link
Contributor

Which issue does this PR close?

Part of #16915

Rationale for this change

Format code examples in documentation comments to improve readability and maintain consistent code style across the codebase. This is part of a multi-PR effort to format all doc comment examples and eventually enable CI checks to enforce this formatting.

What changes are included in this PR?

Run cargo fmt -p <crate> -- --config format_code_in_doc_comments=true for the following datasource-related crates:

  • datafusion-functions
  • datafusion-functions-aggregate
  • datafusion-functions-aggregate-common
  • datafusion-functions-nested
  • datafusion-functions-table
  • datafusion-functions-window
  • datafusion-functions-window-common

Are these changes tested?

No testing needed - this is purely a formatting change with no functional modifications.

Are there any user-facing changes?

No - this only affects documentation formatting.

@github-actions github-actions bot added the functions Changes to functions implementation label Oct 29, 2025
@CuteChuanChuan
Copy link
Contributor Author

I see the CI failed. Let me investigate the error and will fix it shortly.

Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @CuteChuanChuan 👍

@alamb alamb added this pull request to the merge queue Nov 3, 2025
@alamb
Copy link
Contributor

alamb commented Nov 3, 2025

Thank you @Weijun-H and @CuteChuanChuan

Merged via the queue into apache:main with commit 69e189d Nov 3, 2025
28 checks passed
@CuteChuanChuan CuteChuanChuan deleted the raymond/16915-format-functions branch November 4, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants