fix: Preserve percent-encoding in PartitionedFile paths during deserialization
#18346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
…rialization (apache#18346) ## Which issue does this PR close? - Closes apache#18345 ## Rationale for this change ## What changes are included in this PR? This PR changes the implementation to use Path::parse(proto.path). As per the object_store crate's documentation, Path::parse is the correct method for constructing a Path from a raw, already-encoded string, as it preserves the encoding. ## Are these changes tested? Yes, with unit tests. ## Are there any user-facing changes? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PartitionedFileduring deserialization is not respected #18345Rationale for this change
What changes are included in this PR?
This PR changes the implementation to use Path::parse(proto.path). As per the object_store crate's documentation, Path::parse is the correct method for constructing a Path from a raw, already-encoded string, as it preserves the encoding.
Are these changes tested?
Yes, with unit tests.
Are there any user-facing changes?
No.