-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Temporarily disable failing sql_planner benchmark query
#17809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sql_planner benchmark querysql_planner benchmark query
|
This may not be necessary given @pepijnve is working on a real fix: #17801 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give an approval here, in case we still want this.
|
Proposed fix is in #17813. It uncovers the same issue that the benchmark is hitting in one of the tpc-ds tests by removing a double logical plan optimisation and then fixes the problem by introducing a small refinement to the nullability reporting of case expressions. |
|
Since I had some non trivial comments on
I'll also prepare a revert PR so we can back it out Thanks for bearing with us @pepijnve |
|
Thank you for the approval @xudong963 |
This reverts commit 5cc0be5.
This reverts commit 5cc0be5.
Which issue does this PR close?
Rationale for this change
I am trying to run some benchmarks with @pepijnve on
#17419 but the benchmark queries are
now failing.
In order to unblock testing, I would like to disable the panic'ing query in the benchmark code until we fix the underlying issue.
What changes are included in this PR?
Skip the failing test
Are these changes tested?
I tested this manually that the previously failing code
Now runs to completion
Are there any user-facing changes?
No, this is a benchmarking change only