fix: Add missing member to visitor for ConfigFileEncryptionProperties #17103
+58
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Corwin Joy <[email protected]>
|
I'm unsure what's causing the failed CI test. I don't see an error locally, and it is flagging a nonexistent line number, so I don't know what to fix. |
Signed-off-by: Corwin Joy <[email protected]>
alamb
approved these changes
Aug 10, 2025
There was a problem hiding this comment.
Thanks @corwinjoy
I'll update to the latest main and hopefully the Ci will pass then
adamreeve
reviewed
Aug 10, 2025
|
Thanks @corwinjoy and @adamreeve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The visit function for
ConfigFileEncryptionproperties failed to visit the membercolumn_encryption_properties.What changes are included in this PR?
entriesmethod forTableParquetOptionsto facilitate testing and usage for this struct.Are these changes tested?
Yes. A simple unit test was added to test the resulting
entries.Are there any user-facing changes?
TableParquetOptionshas a newentriesmethod.