fix(build-wasm): put arrow-ipc/zstd dep under compression feature
#16844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvander
changed the title
arrow-ipc/zstd dep under compression feature…arrow-ipc/zstd dep under compression feature
alamb
approved these changes
Jul 21, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thank you @chrisvander
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Aug 25, 2025
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Sep 5, 2025
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Sep 5, 2025
erratic-pattern
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 6, 2025
erratic-pattern
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
cc-rsthroughzstd, fails #16843.Rationale for this change
zstdrequires Clang and native feature sets, and forwasm32-unknown-unknowntargets, you may want to opt out of using compression altogether.What changes are included in this PR?
Puts the
arrow-ipczstdoptional dependency behind thecompressionfeature flag.Are these changes tested?
Covered by existing tests and compilation.
Are there any user-facing changes?
No.