Minor: eliminate unnecessary struct creation in session state build #15800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
changed the title
waynexia
approved these changes
Apr 22, 2025
Member
waynexia
left a comment
waynexia
left a comment
There was a problem hiding this comment.
👍
I'm wondering if there is a clippy rule for this case
Contributor
Author
I think it a good idea, I am trying to do it like what have been done about |
xudong963
approved these changes
Apr 22, 2025
Member
|
Thank you |
This was referenced Apr 22, 2025
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I found some unnecessary struct creation in
SessionStateBuilder::builddue to usingunwrap_or, and switch tounwrap_or_elsecan eliminate them.What changes are included in this PR?
Use
unwrap_or_elseto slightly improveSessionStateBuilder::build.Are these changes tested?
Not need
Are there any user-facing changes?
No.