Skip to content

replace CASE expressions in predicate pruning with boolean algebra #13795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 20, 2024
Merged

replace CASE expressions in predicate pruning with boolean algebra #13795

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5442065
replace CASE expressions in predicate pruning with boolean algebra
adriangb Dec 16, 2024
00ab0e5
fix merge
adriangb Dec 16, 2024
4b4004c
update tests
adriangb Dec 16, 2024
87b76d2
add some more tests
adriangb Dec 16, 2024
1e278a4
add some more tests
adriangb Dec 16, 2024
74f3280
remove duplicate test case
adriangb Dec 17, 2024
b0dc5c3
Update datafusion/physical-optimizer/src/pruning.rs
adriangb Dec 17, 2024
4007358
swap NOT for !=
adriangb Dec 17, 2024
fc70ba9
replace comments, update docstrings
adriangb Dec 17, 2024
b9fe799
fix example
adriangb Dec 17, 2024
b2ee6b5
update tests
adriangb Dec 17, 2024
403bde8
update tests
adriangb Dec 17, 2024
95f962e
Apply suggestions from code review
adriangb Dec 19, 2024
df3b2bb
Update pruning.rs
adriangb Dec 19, 2024
c731324
Update pruning.rs
adriangb Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/core/src/datasource/physical_plan/parquet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2002,7 +2002,7 @@ mod tests {

assert_contains!(
&display,
"pruning_predicate=CASE WHEN c1_null_count@2 = c1_row_count@3 THEN false ELSE c1_min@0 != bar OR bar != c1_max@1 END"
"pruning_predicate=c1_null_count@2 != c1_row_count@3 AND (c1_min@0 != bar OR bar != c1_max@1)"
);

assert_contains!(&display, r#"predicate=c1@0 != bar"#);
Expand Down
Loading
Loading